Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Egypt Holidays #35

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Add Egypt Holidays #35

merged 8 commits into from
Jan 31, 2024

Conversation

michaelnabil230
Copy link
Contributor

There are variable holidays, but they depend on the sighting of the moon.

Reference: https://www.timeanddate.com/holidays/egypt/2024

@Nielsvanpach
Copy link
Member

Could you rebase your branch on our main branch? That way I can run the tests

@michaelnabil230
Copy link
Contributor Author

Alright, I think it's done :)

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/Countries/Egypt.php Outdated Show resolved Hide resolved
src/Countries/Egypt.php Outdated Show resolved Hide resolved
src/Countries/Egypt.php Show resolved Hide resolved
@Nielsvanpach
Copy link
Member

This is how other countries solved the islamic holidays:

@michaelnabil230
Copy link
Contributor Author

I can't be sure if it's true or not because I'm a Christian :(

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit c2ce9ce into spatie:main Jan 31, 2024
8 checks passed
@michaelnabil230 michaelnabil230 deleted the egypt branch January 31, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants